fix: QA 이모지 변경 터치 영역 수정#343
Merged
Merged
Conversation
added 7 commits
June 1, 2026 15:57
Member
|
@coderabbitai summary |
clxxrlove
reviewed
Jun 3, 2026
Comment on lines
+241
to
+243
| Text(store.startDateText) | ||
| .typography(.b2_14r) | ||
| .foregroundStyle(Color.Gray.gray500) |
Member
There was a problem hiding this comment.
이 dropDownButton이 모든 row에서 재사용되는 걸로 보이는데, 내부 값이 store.startDateText로 하드코딩되면, 반복 주기 row나 종료일 row도 시작일을 표시하게 될거같아.
dropDownButton(text:action:)처럼 텍스트를 인자로 받고, 각 row에서 periodCountText, startDateText, endDateText를 각각 전달하도록 하는건 어때??
Contributor
Author
There was a problem hiding this comment.
큰일날뻔 ㄷㄷ 마지막 pr에서 반영할게
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 내역